0000067: Build error with GCC 4.5 - Scorched3D

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0000067

Scorched3D

Server

public

2010-10-20 05:15

2010-10-20 17:29

Reporter

dirtyepic

Assigned To

gcamp

Priority

normal

Severity

minor

Reproducibility

always

Status

resolved

Resolution

fixed

Platform

Linux

OS Version

Any

Product Version

43.1c

Target Version

Fixed in Version

43.2

Summary

0000067: Build error with GCC 4.5

Description

The attached patch fixes this build error with GCC 4.5:

x86_64-unknown-linux-gnu-g++ -DPACKAGE_NAME=\"\" -DPACKAGE_TARNAME=\"\"
-DPACKAGE_VERSION=\"\" -DPACKAGE_STRING=\"\" -DPACKAGE_BUGREPORT=\"\"
-DPACKAGE_URL=\"\" -DPACKAGE=\"scorched3d\" -DVERSION=\"43\" -DHAVE_OGG=1
-DHAVE_VSNPRINTF=1 -DHAVE_SNPRINTF=1 -DHAVE_VASPRINTF=1 -DHAVE_ASPRINTF=1
-DHAVE_ICONV=1 -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_UNISTD_H=1
-DHAVE_ICONV_H=1 -I. -I../../common/porting -I../../common -I../../server
-DS3D_SERVER=1 -I/usr/include/SDL -D_GNU_SOURCE=1 -D_REENTRANT
-I/usr/include/mysql -DHAVE_ERRNO_AS_DEFINE=1 -DUNIV_LINUX -DUNIV_LINUX
-DHAVE_MYSQL=1 -O2 -march=core2 -msse4.1 -mcx16 -msahf --param
l1-cache-size=32 --param l1-cache-line-size=64 --param l2-cache-size=6144
-mtune=generic -pipe -ftree-vectorize
-DS3D_DOCDIR=\"/usr/share/doc/scorched3d-43.1c\"
-DS3D_DATADIR=\"/usr/share/games/scorched3d\" -DS3D_BINDIR=\"/usr/games/bin\"
-c -o ServerAuthHandlerForumLogin.o `test -f
'../server/ServerAuthHandlerForumLogin.cpp' || echo
'./'`../server/ServerAuthHandlerForumLogin.cpp

../server/ServerAuthHandlerForumLogin.cpp: In member function 'bool
ServerAuthHandlerForumLogin::connectHandler()':
../server/ServerAuthHandlerForumLogin.cpp:255:84: error: cannot pass objects of
non-trivially-copyable type 'struct std::string' through '...'
make[3]: *** [ServerAuthHandlerForumLogin.o] Error 1

Additional Information

Gentoo Bug #339745
https://bugs.gentoo.org/339745 [^]

Tags

No tags attached.

Attached Files

scorched3d-43.1c-gcc45.patch [^] (656 bytes) 2010-10-20 05:15 [Show Content] [Hide Content]

diff --git a/src/server/server/ServerAuthHandlerForumLogin.cpp b/src/server/server/ServerAuthHandlerForumLogin.cpp
index 58496d4..fbdd9fc 100644
--- a/src/server/server/ServerAuthHandlerForumLogin.cpp
+++ b/src/server/server/ServerAuthHandlerForumLogin.cpp
@@ -252,7 +252,7 @@ bool ServerAuthHandlerForumLogin::connectHandler()
 		!file.getRootNode()->getNamedChild("passwd", passwd) ||
 		!file.getRootNode()->getNamedChild("db", db)) 
 	{
-		Logger::log(S3D::formatStringBuffer("Failed to parse %s settings file.", fileName));
+		Logger::log(S3D::formatStringBuffer("Failed to parse %s settings file.", fileName.c_str()));
 		return false;
 	}

Relationships

Notes
(0000075) gcamp (administrator) 2010-10-20 17:29	Thanks. Fixed in commit 420.

Issue History
Date Modified	Username	Field	Change
2010-10-20 05:15	dirtyepic	New Issue
2010-10-20 05:15	dirtyepic	File Added: scorched3d-43.1c-gcc45.patch
2010-10-20 17:29	gcamp	Note Added: 0000075
2010-10-20 17:29	gcamp	Status	new => resolved
2010-10-20 17:29	gcamp	Fixed in Version	=> 43.2
2010-10-20 17:29	gcamp	Resolution	open => fixed
2010-10-20 17:29	gcamp	Assigned To	=> gcamp